Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Dec 5, 2022

What does this PR do?

Similar to #20554, but this time for classifier_dropout.
The existing checkpoints with this attribute in their config files could still be loaded via the **kwargs --> so won't fail.

@sgugger If you would prefer me to cleanup multiple different unused config attributes in a single PR, let me know 😉

@ydshieh ydshieh requested review from NielsRogge and sgugger December 5, 2022 16:02
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 5, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@NielsRogge NielsRogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ydshieh ydshieh merged commit 4430b91 into main Dec 5, 2022
@ydshieh ydshieh deleted the cleanup_config_attrs_2 branch December 5, 2022 17:04
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants