Skip to content

Conversation

@NielsRogge
Copy link
Contributor

@NielsRogge NielsRogge commented Dec 7, 2022

What does this PR do?

This PR adds the NatBackbone and DinatBackbone classes, to be used for #20577.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Dec 7, 2022

The documentation is not available anymore as the PR was closed or merged.

@NielsRogge NielsRogge changed the title [NAT] Add backbone class [NAT, DiNAT] Add backbone class Dec 7, 2022
@NielsRogge NielsRogge requested a review from sgugger December 7, 2022 19:25
@NielsRogge NielsRogge marked this pull request as ready for review December 7, 2022 19:25
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding those! Please make sure to merge this after #20675 and #20660, and properly include the changes in those PRs to the new backbones here.

@NielsRogge NielsRogge requested a review from sgugger December 12, 2022 10:52
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go with a last couple of nits!

@NielsRogge NielsRogge merged commit 6ef4258 into huggingface:main Dec 13, 2022
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
* Add first draft

* Add out_features attribute to config

* Add corresponding test

* Add Dinat backbone

* Add BackboneMixin

* Add Backbone mixin, improve tests

* Fix embeddings

* Fix bug

* Improve backbones

* Fix Nat backbone tests

* Fix Dinat backbone tests

* Apply suggestions

Co-authored-by: Niels Rogge <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants