[Backbones] Improve out features #20675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
Dec 8, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks for working on this! Good to merge after the docstrings are fixed!
src/transformers/models/maskformer/configuration_maskformer_swin.py
Outdated
Show resolved
Hide resolved
alaradirik
approved these changes
Dec 9, 2022
Contributor
alaradirik
left a comment
alaradirik
left a comment
There was a problem hiding this comment.
Thanks for working on this, LGTM!
mpierrau
pushed a commit
to mpierrau/transformers
that referenced
this pull request
Dec 15, 2022
* Improve ResNet backbone * Improve Bit backbone * Improve docstrings * Fix default stage * Apply suggestions from code review Co-authored-by: Niels Rogge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes sure backbones by default return the feature map of the last stage in case
config.out_features = None.