Skip to content

Raise diff tolerance value for TFViTMAEModelTest #16483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydshieh merged 2 commits into from
Mar 29, 2022
Merged

Raise diff tolerance value for TFViTMAEModelTest #16483

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a347fc3
up
ydshieh Mar 29, 2022
cc166ad
up
ydshieh Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/vit_mae/test_modeling_tf_vit_mae.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,9 @@ def check_outputs(tf_outputs, pt_outputs, model_class, names):
tf_outputs[pt_nans] = 0

max_diff = np.amax(np.abs(tf_outputs - pt_outputs))
self.assertLessEqual(max_diff, 1e-5)
# Set a higher tolerance (2e-5) here than the one in the common test (1e-5).
# TODO: A deeper look to decide the best (common) tolerance for the test to be strict but not too flaky.
self.assertLessEqual(max_diff, 2e-5)
else:
raise ValueError(
f"`tf_outputs` should be a `tuple` or an instance of `tf.Tensor`. Got {type(tf_outputs)} instead."
Expand Down