Skip to content

Comments

Raise diff tolerance value for TFViTMAEModelTest#16483

Merged
ydshieh merged 2 commits intohuggingface:mainfrom
ydshieh:raise_diff_tol_value
Mar 29, 2022
Merged

Raise diff tolerance value for TFViTMAEModelTest#16483
ydshieh merged 2 commits intohuggingface:mainfrom
ydshieh:raise_diff_tol_value

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Mar 29, 2022

What does this PR do?

For now, change the tol from 1e-5 to 2e-5 in TFViTMAEModelTest.test_pt_tf_model_equivalence to avoid being flaky.

@ydshieh ydshieh requested a review from sgugger March 29, 2022 19:26
@ydshieh ydshieh changed the title Raise diff tol value Raise diff tolerance value for TFViTMAEModelTest.test_pt_tf_model_equivalence Mar 29, 2022
@ydshieh ydshieh changed the title Raise diff tolerance value for TFViTMAEModelTest.test_pt_tf_model_equivalence Raise diff tolerance value for TFViTMAEModelTest Mar 29, 2022
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 29, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@ydshieh ydshieh merged commit 2b48323 into huggingface:main Mar 29, 2022
@ydshieh ydshieh deleted the raise_diff_tol_value branch March 29, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants