Skip to content

Fix TFEncDecModelTest - Pytorch device #15979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ydshieh merged 5 commits into from
Mar 8, 2022
Merged

Fix TFEncDecModelTest - Pytorch device #15979

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f53e04
fix device
ydshieh Mar 7, 2022
793bdd6
fix output device
ydshieh Mar 7, 2022
4a2d423
fix more output device
ydshieh Mar 7, 2022
20bd4b2
another approach
ydshieh Mar 8, 2022
921c1ad
fix
ydshieh Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/encoder_decoder/test_modeling_tf_encoder_decoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,9 @@ def check_pt_tf_equivalence(self, pt_model, tf_model, inputs_dict):
if "labels" in pt_inputs:
pt_inputs["labels"] = pt_inputs["labels"].type(torch.LongTensor)

# send pytorch inputs to the correct device
pt_inputs = {k: v.to(device=torch_device) if isinstance(v, torch.Tensor) else v for k, v in pt_inputs.items()}

with torch.no_grad():
pt_outputs = pt_model(**pt_inputs).to_tuple()

Expand All @@ -333,7 +336,7 @@ def check_pt_tf_equivalence(self, pt_model, tf_model, inputs_dict):
self.assertEqual(len(tf_outputs), len(pt_outputs), "Output lengths differ between TF and PyTorch")

for tf_output, pt_output in zip(tf_outputs, pt_outputs):
self.assert_almost_equals(tf_output.numpy(), pt_output.numpy(), 1e-3)
self.assert_almost_equals(tf_output.numpy(), pt_output.detach().to("cpu").numpy(), 1e-3)

# PT -> TF
with tempfile.TemporaryDirectory() as encoder_tmp_dirname, tempfile.TemporaryDirectory() as decoder_tmp_dirname:
Expand All @@ -353,7 +356,7 @@ def check_pt_tf_equivalence(self, pt_model, tf_model, inputs_dict):
self.assertEqual(len(tf_outputs_loaded), len(pt_outputs), "Output lengths differ between TF and PyTorch")

for tf_output_loaded, pt_output in zip(tf_outputs_loaded, pt_outputs):
self.assert_almost_equals(tf_output_loaded.numpy(), pt_output.numpy(), 1e-3)
self.assert_almost_equals(tf_output_loaded.numpy(), pt_output.detach().to("cpu").numpy(), 1e-3)

def check_equivalence_pt_to_tf(self, config, decoder_config, inputs_dict):

Expand Down