Fix TFEncDecModelTest - Pytorch device #15979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
ydshieh
changed the title
patrickvonplaten
approved these changes
Mar 8, 2022
Contributor
patrickvonplaten
left a comment
patrickvonplaten
left a comment
There was a problem hiding this comment.
Looks good to me! Don't really know why the doc builder is failing
sgugger
approved these changes
Mar 8, 2022
Collaborator
sgugger
left a comment
sgugger
left a comment
There was a problem hiding this comment.
Thanks a lot for fixing! doc-builder failure is unrelated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix pytorch device issue for
test_pt_tf_equivalenceinTFEncoderDecoderMixin.@patrickvonplaten @sgugger
Remark:
There are other issues to fix for TFEncoderDecoder test pass:
test_real_model_save_load_from_pretrainedtest_bert2bert_summarizationtest fails after TF generate refactor - Greedy Search #15562Think these should be addressed in separate PRs (especially for 2.)