Fix squared optimization steps bug in distillation trainer#284
Merged
tomaarsen merged 1 commit intohuggingface:mainfrom Jan 23, 2023
Merged
Fix squared optimization steps bug in distillation trainer#284tomaarsen merged 1 commit intohuggingface:mainfrom
tomaarsen merged 1 commit intohuggingface:mainfrom
Conversation
Based on the bug fix from huggingface#280
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
Details
The
trainmethod for the distillation trainer is very similar to thetrainmethod on the regular trainer. As a result, it also contained the bug from #280 and the corresponding fix could be copied from there without any issues. For additional details, see that PR or #268 (comment) which originally showcases the bug.