[fix] Simplify save_to_hub, remove git dependency, add 'token' argument#2376
Merged
tomaarsen merged 6 commits intohuggingface:masterfrom Dec 13, 2023
Merged
[fix] Simplify save_to_hub, remove git dependency, add 'token' argument#2376tomaarsen merged 6 commits intohuggingface:masterfrom
fix] Simplify save_to_hub, remove git dependency, add 'token' argument#2376tomaarsen merged 6 commits intohuggingface:masterfrom
Conversation
black with line length of 120
100% (but mocked) coverage on save_to_hub
transformers>4.32.0 is required for 'token' huggingface_hub>=0.15.1 is required by transformers
Thanks @Wauplin for the help
osanseviero
reviewed
Dec 13, 2023
This was referenced Dec 14, 2023
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1777, Fixes #1760, Fixes #1925
Hello!
Pull Request overview
save_to_hub:git-lfsdoesn't need to work.upload_folderfrom legacyRepository+ git-lfs.tokenargument. Doesn't need to be provided ifhuggingface-cli loginhas been done.NOTE:save_to_hubnow returns the URL to the uploaded model files, not the commit!transformers>=4.32.0, required fortokenas used inmainhuggingface_hub>=0.15.1as required bytransformers>=4.32.0Details
The huggingface_hub has updated its recommended workflow on how to upload files, and this PR follows the updated version.
NOTE:save_to_hubnow returns the URL to the uploaded model files, not the commit! I theorize that this is not a big issue, as I don't suspect many people to use the returned URL.E.g.