Skip to content

Fix to issue #1760#1868

Closed
iampushpdeep wants to merge 1 commit intohuggingface:masterfrom
iampushpdeep:pushpdeep
Closed

Fix to issue #1760#1868
iampushpdeep wants to merge 1 commit intohuggingface:masterfrom
iampushpdeep:pushpdeep

Conversation

@iampushpdeep
Copy link

@iampushpdeep iampushpdeep commented Mar 18, 2023

Fix to issue #1760

Fixed to issue[huggingface#1760] of uploading the model to HuggingFace Hub
@iampushpdeep iampushpdeep changed the title update SentenceTransformer.py Fix to issue 1760(HF Hub) Mar 18, 2023
@iampushpdeep iampushpdeep changed the title Fix to issue 1760(HF Hub) Fix to issue #1760 Mar 18, 2023
@dbuades
Copy link

dbuades commented Apr 11, 2023

I can confirm that this PR fixes the issue.

@davidbetancur8
Copy link

any updates on this?

@Jakobhenningjensen
Copy link

Jakobhenningjensen commented Jul 13, 2023

Any updates on when this will be merged? It's a rather critical issue

@andersonbcdefg
Copy link

Hey, still need this fix please!!!!

@tomaarsen
Copy link
Member

Hello!

#2376 has resolved this issue, while preserving backwards compatibility. It will be released in the next Sentence Transformers 2.3.0 release. Thanks for pointing me to this problem via this PR!

  • Tom Aarsen

@tomaarsen tomaarsen closed this Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants