Skip to content

HfAPi().create_repo positional arguments to keyword arguments #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fgbelidji wants to merge 1 commit into from
Closed

HfAPi().create_repo positional arguments to keyword arguments #1732

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sentence_transformers/SentenceTransformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,8 +465,8 @@ def save_to_hub(self,

endpoint = "https://huggingface.co"
repo_url = HfApi(endpoint=endpoint).create_repo(
token,
repo_name,
token=token,
repo_id=repo_name,
Copy link
Copy Markdown

@Wauplin Wauplin Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The organization parameter is deprecated and will soon be removed in next release of huggingface_hub (a Warning message should already be printed since version 0.8).

Suggested change is to add organization to the repo id and remove it from the arguments passed to create_repo.

Suggested change
repo_id=repo_name,
repo_id=f"{organization}/{repo_name}",

Copy link
Copy Markdown
Contributor

@osanseviero osanseviero Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Organization might be None though and that would lead to an error I think.

Maybe we should go ahead with #1743 ?

Copy link
Copy Markdown

@Wauplin Wauplin Nov 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry, my bad. Checking this would be better :)

organization=organization,
private=private,
repo_type=None,
Expand Down