Fix save_to_hub for last huggingface_hub version#1743
Merged
nreimers merged 1 commit intohuggingface:masterfrom Nov 14, 2022
Merged
Fix save_to_hub for last huggingface_hub version#1743nreimers merged 1 commit intohuggingface:masterfrom
nreimers merged 1 commit intohuggingface:masterfrom
Conversation
Contributor
Author
|
cc @nreimers |
Collaborator
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1742
This should work both with old and new
huggingface_hubversionsorganizationandnameparameters have been deprecated since some releases ago, and it was announced they were going to be deprecated in favour ofrepo_id. At the same time, positional parameters are no longer supported, which led to users not being able to push with the latest version ofhuggingface_hub