Revert "Synapse 1.15 addition2 (#844)"#850
Merged
Merged
Conversation
This reverts commit 844908d.
regisss
reviewed
Mar 29, 2024
Collaborator
regisss
left a comment
regisss
left a comment
There was a problem hiding this comment.
Looks good, there's just one change in the commit you're reverting that we should keep
regisss
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 844908d.
What does this PR do?
This PR fixes huge perf regression in LLaMA2-70B MLPerf scenario (using tgi-gaudi).
PR #849 does not solve the issue so I recommend to fix synapse_1.15 first and then see how the issue with TGI can be resolved.
CC @libinta @kdamaszk @regisss