Remove contingous call#849
Closed
libinta wants to merge 21 commits into
Closed
Conversation
…817) Co-authored-by: Dudi Lester <160421192+dudilester@users.noreply.github.com>
Co-authored-by: Sun Choi <schoi@habana.ai>
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
…Gaudi2 (#779) Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Co-authored-by: Sun Choi <schoi@habana.ai> Co-authored-by: Pankaj Dixit <pdixit@habana.ai> Co-authored-by: Yeonsil Yoon <yyoon@habana.ai> Co-authored-by: Vivek <vgoel@habana.ai> Co-authored-by: Libin Tang <litang@habana.ai> Co-authored-by: Shiv Kaul <skaul@habana.ai>
Co-authored-by: Libin Tang <litang@habana.ai> Co-authored-by: Yeonsil Yoon <yyoon@habana.ai>
…e case such as TGI. Remove it for performance improvement.
szutenberg
suggested changes
Mar 29, 2024
Contributor
szutenberg
left a comment
szutenberg
left a comment
There was a problem hiding this comment.
This change does not solve the issue with performance regression in the TGI MLPerf scenario.
My proposal is to revert 844908d which introduced the regression. I'll push PR shortly.
regisss
requested review from
bhargaveede,
hlahkar,
ssarkar2 and
vivekgoe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The contingous call causes performance degradation for not reuse_cache case such as TGI.
Remove it for performance improvement.
Fixes # (issue)
Before submitting