Fix for Falcon error from PR #587#608
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
libinta
approved these changes
Dec 21, 2023
dsocek
pushed a commit
to dsocek/optimum-habana
that referenced
this pull request
Jan 4, 2024
* Fix for Falcon error from PR huggingface#587 * Reformatted
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the PR #587, Falcon inference fails with Synapse 1.13.0 because this comparison in here always returns False.
optimum-habana/optimum/habana/utils.py
Line 343 in 21238af
This is because get_habana_frameworks_version() returns 1.13.0.xxx whereas version.parse(req_version) is 1.13.0.
Thus this PR was created to compare the major and minor versions.
Before submitting