fea(gemma2): cleaned up old codes#2212
Merged
Merged
Conversation
yafshar
reviewed
Aug 19, 2025
yafshar
approved these changes
Aug 19, 2025
Contributor
yafshar
left a comment
There was a problem hiding this comment.
@imangohari1 please address the comment. Except that everything looks good to me. Thanks for the clean up :)
LGTM!
@regisss please do the final check on this PR.
Contributor
Author
Done. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
astachowiczhabana
pushed a commit
that referenced
this pull request
Aug 29, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 17, 2025
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates on Gemma2 with clean up on old, local implementations of KVCache, MLP, Rotary etc with the unified ones.
conducted Tests
CI (only Gemma2)
Readme tests
LM_eval with 8k max new token
Fixes # (issue)
Before submitting