Fix CWE-561 Dead Code Vulnerability related to use_new_cache = False#2254
Merged
regisss merged 2 commits intoSep 11, 2025
Merged
Conversation
karol-brejna-i
requested review from
libinta,
mandy-li and
regisss
as code owners
|
The code quality check failed, please run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
pbielak
approved these changes
Sep 11, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 12, 2025
astachowiczhabana
pushed a commit
that referenced
this pull request
Sep 17, 2025
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
huggingface#2254) (huggingface#675) Co-authored-by: Karol Brejna <karolbrejna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CWE-561 Dead Code Vulnerability related to
use_new_cache = FalseMultiple model implementations in the optimum-habana codebase contained dead code that violated CWE-561 (Dead Code)** security standards.
use_new_cachewas explicitly hardcoded toFalsefor HPU optimizationif use_new_cache:were still present but never executedThis PR removes the dead code and allows us to pass security scans.