Added check if reuse_cache supported by selected model_type#675
Merged
Conversation
iermolae
requested review from
bhargaveede,
ssarkar2 and
vivekgoe
as code owners
ssarkar2
approved these changes
Jan 31, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
jychen21
pushed a commit
to jychen21/optimum-habana
that referenced
this pull request
Feb 27, 2024
HolyFalafel
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Mar 11, 2024
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
huggingface#2254) (huggingface#675) Co-authored-by: Karol Brejna <karolbrejna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a check if reuse_cache flag supported by selected model_type in GaudiGenerationMixin.generate()
Previously, if run_generation.py ran with other than "llama" model and --reuse_check there was an error:
AttributeError: 'GaudiMistralForCausalLM' object has no attribute 'allocate_kv_cache'Now there is a more user-freindly message describing the problem:
AssertionError: reuse_cache only supported by llama at the moment