mixtral: drop training-branching hack for SFT segfault#2169
Closed
yafshar wants to merge 1 commit into
Closed
Conversation
The workaround that chose between `call_sparse_moe_op` (training) and `call_dynamic_moe_op` (inference) was introduced to avoid a segmentation fault during SFT training on earlier Synapse releases. (See PR huggingface#1798) The underlying bug is fixed in Synapse 1.21.0, so the hack is no longer needed. Replace the branching logic with the unified `torch.ops.hpu.mixture_of_experts` call for both training and inference, and remove the TODO comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What
Removes the temporary workaround that selected different MOE kernels depending on
self.training.After Synapse 1.21.0, the segmentation fault (See PR #1798) that originally motivated the hack is resolved,
so we can now use a single HPU-optimized kernel for both training and inference.
Changes
if self.training … else …branch.call_sparse_moe_opandcall_dynamic_moe_opcalls withtorch.ops.hpu.mixture_of_experts, passing the weight lists (w1_list,w2_list,w3_list).Tests:
main
this PR
text-generation
main
this PR
Before submitting