[1.20.0] Temporary workaround to avoid segmentation fault#1798
Merged
Conversation
…ning - Added call_sparse_moe_op for training - Added conditional logic to use call_sparse_moe_op during training to prevent segmentation faults. - TODO: This is a temporary solution. Remove this section after the issue is fixed.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
pushed a commit
that referenced
this pull request
Feb 26, 2025
yafshar
added a commit
to yafshar/optimum-habana
that referenced
this pull request
Jul 23, 2025
The workaround that chose between `call_sparse_moe_op` (training) and `call_dynamic_moe_op` (inference) was introduced to avoid a segmentation fault during SFT training on earlier Synapse releases. (See PR huggingface#1798) The underlying bug is fixed in Synapse 1.21.0, so the hack is no longer needed. Replace the branching logic with the unified `torch.ops.hpu.mixture_of_experts` call for both training and inference, and remove the TODO comment.
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a temporary workaround to avoid segmentation fault during SFT training
Fixes # (issue)
The example from
examples/trlwith fewer steps here for faster reproduction.main
this PR
Other cases tested
Before submitting