Skip to content

Fix test_calculate_loss failure by updating peft to version 0.15.0#2168

Closed
gplutop7 wants to merge 1 commit into
huggingface:v1.19-releasefrom
HabanaAI:v1.19-release_peft_0_15_0
Closed

Fix test_calculate_loss failure by updating peft to version 0.15.0#2168
gplutop7 wants to merge 1 commit into
huggingface:v1.19-releasefrom
HabanaAI:v1.19-release_peft_0_15_0

Conversation

@gplutop7
Copy link
Copy Markdown
Collaborator

This PR updates the peft dependency to version 0.15.0 to resolve an import error triggered by recent changes in the diffusers library.

Updated peft from ==0.12.0 to ==0.15.0.

Failing Test:
pytest tests/test_trl.py -v -s -k "test_calculate_loss"

@gplutop7 gplutop7 requested a review from regisss as a code owner July 22, 2025 15:44
@yafshar
Copy link
Copy Markdown
Contributor

yafshar commented Jul 22, 2025

@gplutop7 please check the main branch and #2160 PR. This has already been addressed on main
@astachowiczhabana would you merge that PR in the 1.19-release

@imangohari1
Copy link
Copy Markdown
Contributor

imangohari1 commented Jul 23, 2025

This pr is not needed. the issue is fixed in #2160.

@regisss @libinta @astachowiczhabana please close.

@gplutop7 gplutop7 closed this Jul 24, 2025
@gplutop7 gplutop7 reopened this Jul 24, 2025
@gplutop7
Copy link
Copy Markdown
Collaborator Author

This pr is not needed. the issue is fixed in #2160.

@regisss @libinta @astachowiczhabana please close.

Hi, quick question – has your PR #2160 been included in the 1.19-release branch?
At the moment I can see it was merged into main, but not yet cherry-picked or merged into 1.19-release.
Thanks in advance for confirming!

@regisss
Copy link
Copy Markdown
Collaborator

regisss commented Jul 24, 2025

This pr is not needed. the issue is fixed in #2160.
@regisss @libinta @astachowiczhabana please close.

Hi, quick question – has your PR #2160 been included in the 1.19-release branch? At the moment I can see it was merged into main, but not yet cherry-picked or merged into 1.19-release. Thanks in advance for confirming!

I just did it now! Let me know if that solves your issue?

@imangohari1
Copy link
Copy Markdown
Contributor

This pr is not needed. the issue is fixed in #2160.
@regisss @libinta @astachowiczhabana please close.

Hi, quick question – has your PR #2160 been included in the 1.19-release branch? At the moment I can see it was merged into main, but not yet cherry-picked or merged into 1.19-release. Thanks in advance for confirming!

I just did it now! Let me know if that solves your issue?

Thanks @regisss

@gplutop7 https://github.com/huggingface/optimum-habana/commits/v1.19-release/ has the PR #2160 now. SHA 9929. please confirm. Thank you.

@gplutop7 gplutop7 closed this Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants