Skip to content

fea(trl): updated peft version#2160

Merged
regisss merged 1 commit into
huggingface:mainfrom
imangohari1:ig/trl-perf-0.15.0
Jul 21, 2025
Merged

fea(trl): updated peft version#2160
regisss merged 1 commit into
huggingface:mainfrom
imangohari1:ig/trl-perf-0.15.0

Conversation

@imangohari1
Copy link
Copy Markdown
Contributor

What does this PR do?

tldr; with diffuser update to 0.34.0 #2152 the min requirement for perf is bumped to 0.15.0. trl uses diffuser pipelines and we are bumping the peft version accordingly.

Notes

ImportError: peft>=0.15.0 is required for a normal functioning of this module, but found peft==0.12.0.

Conducted tests

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@imangohari1 imangohari1 requested a review from regisss as a code owner July 18, 2025 18:54
@imangohari1
Copy link
Copy Markdown
Contributor Author

Hi @regisss
This is follow up to the #2152 to fix the peft version for trl. please review.
@yafshar @dsocek @astachowiczhabana FYI

Copy link
Copy Markdown
Contributor

@yafshar yafshar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imangohari1 imangohari1 mentioned this pull request Jul 18, 2025
3 tasks
Copy link
Copy Markdown
Contributor

@dsocek dsocek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (IMO best of 3 proposed solutions)

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit a2a2e48 into huggingface:main Jul 21, 2025
2 of 5 checks passed
regisss pushed a commit that referenced this pull request Jul 24, 2025
astachowiczhabana pushed a commit that referenced this pull request Jul 31, 2025
astachowiczhabana pushed a commit that referenced this pull request Sep 10, 2025
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
Co-authored-by: Iman Gohari <s.m.iman.gohari@intel.com>
Co-authored-by: Marek Strachacki <mstrachacki@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants