Hot fix regional compilation#2005
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
@IlyasMoutawwakil I am getting an error with this PR [INFO|trainer.py:831] 2025-05-27 18:16:00,172 >> Number of trainable parameters = 16,384,000
[rank0]: Traceback (most recent call last):
[rank0]: File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/trainer.py", line 2587, in _zero_model_grad
[rank0]: model.zero_grad(set_to_none=set_to_none)
[rank0]: TypeError: DeepSpeedEngine.zero_grad() got an unexpected keyword argument 'set_to_none'
[rank0]: During handling of the above exception, another exception occurred:
[rank0]: Traceback (most recent call last):
[rank0]: File "/root/optimum-habana/examples/language-modeling/run_lora_clm.py", line 990, in <module>
[rank0]: main()
[rank0]: File "/root/optimum-habana/examples/language-modeling/run_lora_clm.py", line 963, in main
[rank0]: train_result = trainer.train(resume_from_checkpoint=training_args.resume_from_checkpoint)
[rank0]: File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/trainer.py", line 610, in train
[rank0]: return inner_training_loop(
[rank0]: File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/trainer.py", line 882, in _inner_training_loop
[rank0]: self._zero_model_grad(model)
[rank0]: File "/usr/local/lib/python3.10/dist-packages/optimum/habana/transformers/trainer.py", line 2590, in _zero_model_grad
[rank0]: model.zero_grad()
[rank0]: File "/usr/local/lib/python3.10/dist-packages/deepspeed/runtime/engine.py", line 2119, in zero_grad
[rank0]: for param_name, param in self.module.named_parameters():
[rank0]: File "/usr/local/lib/python3.10/dist-packages/deepspeed/runtime/engine.py", line 519, in __getattr__
[rank0]: return getattr(self, name)
[rank0]: File "/usr/local/lib/python3.10/dist-packages/deepspeed/runtime/engine.py", line 519, in __getattr__
[rank0]: return getattr(self, name)
[rank0]: File "/usr/local/lib/python3.10/dist-packages/deepspeed/runtime/engine.py", line 519, in __getattr__
[rank0]: return getattr(self, name)
[rank0]: [Previous line repeated 491 more times]
[rank0]: File "/usr/local/lib/python3.10/dist-packages/deepspeed/runtime/engine.py", line 518, in __getattr__
[rank0]: if name in dir(self):
[rank0]: File "/usr/local/lib/python3.10/dist-packages/torch/nn/modules/module.py", line 2972, in __dir__
[rank0]: module_attrs = dir(self.__class__)
[rank0]: RecursionError: maximum recursion depth exceeded while calling a Python object |
Contributor
|
with the latest fix there is no error for above example |
regisss
added a commit
that referenced
this pull request
Jun 2, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jun 5, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jun 10, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Jul 3, 2025
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
astachowiczhabana
added a commit
that referenced
this pull request
Jul 4, 2025
* Hot fix regional compilation (#2005) Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> * More makefile fixes (#2036) * add token to single card tests * remove non existent diffusers test group * more makefile and cli fixes * fix * Update Makefile --------- Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
gplutop7
pushed a commit
to HabanaAI/optimum-habana-fork
that referenced
this pull request
Oct 15, 2025
* Merge v1.18-release * Hot fix regional compilation (huggingface#2005) Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> * Enable mixtral 8x7b accuracy evaluation (huggingface#1986) Co-authored-by: Rafal <rbogdanowicz@habana.ai> * Update readme files for explicit lazy mode (huggingface#1921) Co-authored-by: Karol Brejna <karol.brejna@intel.com> Co-authored-by: Piotr Bielak <piotr.bielak@intel.com> * [llama-vision] Remove token_idx_cpu parameter (huggingface#2018) Integer parameter token_idx_cpu passed to mllama's forward() method caused an issue with hpu graph cache which led to performance drop. Signed-off-by: Urszula <urszula.golowicz@intel.com> * Update README examples (huggingface#2020) * Fix examples in README audio-classification: - add space between "False" and backslash image-to-text: - add "datasets" to requirements.txt pytorch-image-models: - add "datasets" to requirements.txt sentence-transformers-training/nli: - add command to properly discover HABANA_VISIBLE_MODULES sentence-transformers-training/sts: - add command to properly discover HABANA_VISIBLE_MODULES speech-recognition: - add `--trust_remote_code` for seq2seq examples stable-diffusion/training: - add missing OpenCV requirement for ControlNet Training Co-authored-by: Karol Brejna <karol.brejna@intel.com> * Review fixes: remove grabbing all modules --------- Co-authored-by: Karol Brejna <karol.brejna@intel.com> Co-authored-by: karol-brejna-i <karolbrejna@apache.org> * Pin latest optimum to force mutual updates (huggingface#2016) pin latest optimum to force mutual updates * Fix FP8 support and address related issues (huggingface#2010) - Resolve bugs related to FP8 (floating point 8-bit) computation - Improve stability and correctness of FP8 operations - Add/fix tests to validate FP8 functionality - Update relevant documentation and comments Co-authored-by: IlyasMoutawwakil --------- Signed-off-by: Urszula <urszula.golowicz@intel.com> Co-authored-by: Adam Stachowicz <astachowicz@habana.ai> Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com> Co-authored-by: regisss <15324346+regisss@users.noreply.github.com> Co-authored-by: Rafal Bogdanowicz <rafal.bogdanowicz@intel.com> Co-authored-by: Rafal <rbogdanowicz@habana.ai> Co-authored-by: Jan Kamiński <jkaminski@habana.ai> Co-authored-by: Karol Brejna <karol.brejna@intel.com> Co-authored-by: Piotr Bielak <piotr.bielak@intel.com> Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com> Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com> Co-authored-by: karol-brejna-i <karolbrejna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting