Skip to content

Enable mixtral 8x7b accuracy evaluation#1986

Merged
regisss merged 7 commits into
huggingface:mainfrom
rbogdano:rbogdano/enable-accuracy-tests-for-mixtral8x7b
Jun 3, 2025
Merged

Enable mixtral 8x7b accuracy evaluation#1986
regisss merged 7 commits into
huggingface:mainfrom
rbogdano:rbogdano/enable-accuracy-tests-for-mixtral8x7b

Conversation

@rbogdano
Copy link
Copy Markdown
Contributor

This commit implements accuracy.json generation.
In order to generate inference responses for custom dataset simply run run_generation script with two parameters --dataset custom_dataset.pkl and --dataset_name custom.

Additionaly you can setup environment for mbxp dataset evaluation and evaluate responses by using mlcommon scripts.

Results from the evaluation of the mlcommon dataset, which is a combination of OpenOrca, GSM8K, and MBXP.
{
'rouge1': 45.4708,
'rouge2': 23.2887,
'rougeL': 30.3478,
'rougeLsum': 42.4501,
'gsm8k': 74.16,
'mbxp': 60.36,
'gen_len': 4243067,
'gen_num': 15000,
'gen_tok_len': 2808861,
'tokens_per_sample': 187.3
}

@rbogdano rbogdano requested a review from regisss as a code owner May 19, 2025 14:25
vidyasiv

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@vidyasiv vidyasiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @rbogdano

  • Could you provide me with a custom pickle file for testing this PR?
  • Please also run make style on this PR and fix any issues (I see 2 at my end which need manual fixing).

Comment thread examples/text-generation/README.md
Comment thread examples/text-generation/README.md Outdated
Comment thread examples/text-generation/README.md Outdated
Comment thread examples/text-generation/run_generation.py
@vidyasiv
Copy link
Copy Markdown
Contributor

Contacted author offline, they're busy now and will respond in 1-2 weeks.

Comment thread examples/text-generation/run_generation.py
Comment thread examples/text-generation/README.md
Comment thread examples/text-generation/run_generation.py Outdated
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment thread examples/text-generation/mbxp_evaluation/evaluation_setup/ubuntu.sh
Comment thread examples/text-generation/README.md Outdated
Comment thread examples/text-generation/README.md Outdated
Comment thread examples/text-generation/run_generation.py Outdated
Comment thread examples/text-generation/run_generation.py Outdated
Comment thread examples/text-generation/run_generation.py Outdated
Comment thread examples/text-generation/README.md
Copy link
Copy Markdown
Contributor

@vidyasiv vidyasiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the prompt updates @rbogdano

@rbogdano
Copy link
Copy Markdown
Contributor Author

rbogdano commented Jun 2, 2025

LGTM, thanks for the prompt updates @rbogdano

Thanks for really good review :)

@astachowiczhabana
Copy link
Copy Markdown
Collaborator

@regisss can we merge this to main/1.18. The code is separated and shouldn't disrupt current tests results

Copy link
Copy Markdown
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 2d71a45 into huggingface:main Jun 3, 2025
4 checks passed
regisss pushed a commit that referenced this pull request Jun 3, 2025
Co-authored-by: Rafal <rbogdanowicz@habana.ai>
astachowiczhabana pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jun 5, 2025
Co-authored-by: Rafal <rbogdanowicz@habana.ai>
astachowiczhabana pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Jun 10, 2025
Co-authored-by: Rafal <rbogdanowicz@habana.ai>
gplutop7 pushed a commit to HabanaAI/optimum-habana-fork that referenced this pull request Oct 15, 2025
* Merge v1.18-release

* Hot fix regional compilation (huggingface#2005)

Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>

* Enable mixtral 8x7b accuracy evaluation (huggingface#1986)

Co-authored-by: Rafal <rbogdanowicz@habana.ai>

* Update readme files for explicit lazy mode (huggingface#1921)

Co-authored-by: Karol Brejna <karol.brejna@intel.com>
Co-authored-by: Piotr Bielak <piotr.bielak@intel.com>

* [llama-vision] Remove token_idx_cpu parameter (huggingface#2018)

Integer parameter token_idx_cpu passed to mllama's forward()
method caused an issue with hpu graph cache which led to
performance drop.

Signed-off-by: Urszula <urszula.golowicz@intel.com>

* Update README examples (huggingface#2020)

* Fix examples in README

audio-classification:
- add space between "False" and backslash

image-to-text:
- add "datasets" to requirements.txt

pytorch-image-models:
- add "datasets" to requirements.txt

sentence-transformers-training/nli:
- add command to properly discover HABANA_VISIBLE_MODULES

sentence-transformers-training/sts:
- add command to properly discover HABANA_VISIBLE_MODULES

speech-recognition:
- add `--trust_remote_code` for seq2seq examples

stable-diffusion/training:
- add missing OpenCV requirement for ControlNet Training

Co-authored-by: Karol Brejna <karol.brejna@intel.com>

* Review fixes: remove grabbing all modules

---------

Co-authored-by: Karol Brejna <karol.brejna@intel.com>
Co-authored-by: karol-brejna-i <karolbrejna@apache.org>

* Pin latest optimum to force mutual updates (huggingface#2016)

pin latest optimum to force mutual updates

* Fix FP8 support and address related issues (huggingface#2010)

- Resolve bugs related to FP8 (floating point 8-bit) computation
- Improve stability and correctness of FP8 operations
- Add/fix tests to validate FP8 functionality
- Update relevant documentation and comments

Co-authored-by: IlyasMoutawwakil

---------

Signed-off-by: Urszula <urszula.golowicz@intel.com>
Co-authored-by: Adam Stachowicz <astachowicz@habana.ai>
Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Co-authored-by: Rafal Bogdanowicz <rafal.bogdanowicz@intel.com>
Co-authored-by: Rafal <rbogdanowicz@habana.ai>
Co-authored-by: Jan Kamiński <jkaminski@habana.ai>
Co-authored-by: Karol Brejna <karol.brejna@intel.com>
Co-authored-by: Piotr Bielak <piotr.bielak@intel.com>
Co-authored-by: Urszula Golowicz <urszula.golowicz@intel.com>
Co-authored-by: Piotr Bielak <pbielak@users.noreply.github.com>
Co-authored-by: karol-brejna-i <karolbrejna@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants