Skip to content

fix uv env path + details #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 5, 2025
Merged

fix uv env path + details #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ea97da
fix uv env path + details
edbeeching Feb 5, 2025
9a6086f
Update slurm/grpo.slurm
lewtun Feb 5, 2025
7a46942
Merge branch 'main' into uv-slurm-fixes
lewtun Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions slurm/eval_callback.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@

set -x -e
source ~/.bashrc
conda activate openr1

source openr1/bin/activate
TASK_NAME=$1
TASKS=$2
MODEL_ID=$3
Expand All @@ -31,7 +30,7 @@ fi

LM_EVAL_REPO_ID="open-r1/open-r1-eval-leaderboard"
MODEL_NAME=$(echo $MODEL_ID | sed 's/\//_/g') # replaces / with _
DETAILS_REPO_ID="open-r1//details-$MODEL_NAME"
DETAILS_REPO_ID="open-r1/details-$MODEL_NAME"
OUTPUT_DIR="eval_results/$MODEL_ID/$MODEL_REVISION/$TASK_NAME"
# We need this flag since we run this script from training jobs that use DeepSpeed and the env vars get progated which causes errors during evaluation
ACCELERATE_USE_DEEPSPEED=false
Expand Down
2 changes: 1 addition & 1 deletion slurm/evaluate.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
set -x -e

source ~/.bashrc
conda activate openr1
source openr1/bin/activate
module load cuda/12.1
echo "START TIME: $(date)"
echo "PYTHON ENV: $(which python)"
Expand Down
2 changes: 1 addition & 1 deletion slurm/generate.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export LD_LIBRARY_PATH=.venv/lib/python3.11/site-packages/nvidia/nvjitlink/lib
echo "SLURM_JOB_ID: $SLURM_JOB_ID"
echo "SLURM_JOB_NODELIST: $SLURM_JOB_NODELIST"

source .venv/bin/activate
source openr1/bin/activate

# Getting the node names
nodes=$(scontrol show hostnames "$SLURM_JOB_NODELIST")
Expand Down
2 changes: 1 addition & 1 deletion slurm/grpo.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
set -x -e

source ~/.bashrc
conda activate openr1
source openr1/bin/activate
echo "START TIME: $(date)"
echo "PYTHON ENV: $(which python)"

Expand Down
2 changes: 1 addition & 1 deletion slurm/sft.slurm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
set -x -e

source ~/.bashrc
conda activate openr1
source openr1/bin/activate
echo "START TIME: $(date)"
echo "PYTHON ENV: $(which python)"

Expand Down
2 changes: 1 addition & 1 deletion src/open_r1/utils/upload_details.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class ScriptArguments:

def main():
parser = HfArgumentParser(ScriptArguments)
args = parser.parse()
args = parser.parse_args_into_dataclasses()[0]

if all(file.endswith(".json") for file in args.data_files):
ds = load_dataset("json", data_files=args.data_files)
Expand Down