Skip to content

Conversation

edbeeching
Copy link
Collaborator

#91 broke the slurm scripts, this PR updates them and fixes a bug with pushing details

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a turbo nit

@lewtun
Copy link
Member

lewtun commented Feb 5, 2025

I'm merging since I need this for #196

@lewtun lewtun merged commit 3fd56dc into main Feb 5, 2025
1 check passed
@lewtun lewtun deleted the uv-slurm-fixes branch February 5, 2025 22:59
GitMonkey0 pushed a commit to GitMonkey0/open-r1 that referenced this pull request Feb 24, 2025
* fix uv env path + details

* Update slurm/grpo.slurm

---------

Co-authored-by: lewtun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants