Skip to content

Lift protobuf restriction #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Lift protobuf restriction #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
490c529
lift protobuf restriction
Vectorrent Apr 22, 2025
fbfb105
fix typos
Vectorrent Apr 22, 2025
65632ac
remove incorrect comment
Vectorrent Apr 23, 2025
b13153a
Merge branch 'main' into upgrade-protobuf
NathanHB Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ dependencies = [
"sacrebleu",
"rouge_score==0.1.2",
"sentencepiece>=0.1.99",
"protobuf==3.20.*", # pinned for sentencepiece compat
"protobuf",
"pycountry",
"fsspec>=2023.12.2",
"httpx == 0.27.2",
Expand Down
2 changes: 1 addition & 1 deletion src/lighteval/models/transformers/transformers_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def _init_max_length(self) -> int:
return getattr(self.transformers_config, attr)

logger.warning(
"No max_length attribute found in the model config. Using the default max sequence length setting {2048}. It is recomended to set max_length trough the madel args"
"No max_length attribute found in the model config. Using the default max sequence length setting {2048}. It is recomended to set max_length through the model args"
)

return 2048
Expand Down
Loading