Skip to content

Conversation

clefourrier
Copy link
Member

@clefourrier clefourrier commented Jul 5, 2024

Starting from #207 and #212

@clefourrier clefourrier changed the base branch from main to simplify_task_system July 5, 2024 10:40
@clefourrier clefourrier requested a review from NathanHB July 5, 2024 13:12
@hynky1999
Copy link
Collaborator

Looks great to me, will feel way easier to add new tasks or inspect already defined one now. Thanks 👍

@clefourrier clefourrier changed the base branch from simplify_task_system to main July 9, 2024 12:42
@clefourrier clefourrier requested a review from NathanHB July 9, 2024 12:49
Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if tests pass we can merge :)

@clefourrier clefourrier merged commit 4651531 into main Jul 9, 2024
hynky1999 added a commit that referenced this pull request May 22, 2025
* add function prompt assigment

* add json casting

* fix ruff setting + fmt

* replaced json tasks by python tasks, step 1

* wip

* simplification part 1

* fix extended tasks + typo

* fix

* fix nanotron example

* small fix

* now use function, not string, to pass prompts in examples

* moved everyone to function calling

* LightevalTask now only takes functions

* removed templated type which messed up the test suite

* last fix + doc udpate

* Update src/lighteval/tasks/registry.py

Co-authored-by: Nathan Habib <[email protected]>

---------

Co-authored-by: Hynek Kydlíček <[email protected]>
Co-authored-by: Nathan Habib <[email protected]>
NathanHB added a commit that referenced this pull request Sep 19, 2025
* add function prompt assigment

* add json casting

* fix ruff setting + fmt

* replaced json tasks by python tasks, step 1

* wip

* simplification part 1

* fix extended tasks + typo

* fix

* fix nanotron example

* small fix

* now use function, not string, to pass prompts in examples

* moved everyone to function calling

* LightevalTask now only takes functions

* removed templated type which messed up the test suite

* last fix + doc udpate

* Update src/lighteval/tasks/registry.py

Co-authored-by: Nathan Habib <[email protected]>

---------

Co-authored-by: Hynek Kydlíček <[email protected]>
Co-authored-by: Nathan Habib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants