Skip to content

Conversation

clefourrier
Copy link
Member

@clefourrier clefourrier commented Jul 4, 2024

  • Removes the dict option to load tasks, and replaces tasks_table.jsonl with a new python file
  • Makes the whole system rely on dataclasses and update all tasks

Still need to update doc and readme!

@clefourrier
Copy link
Member Author

@hynky1999 does this fit what you had in mind ? :)

Copy link
Member

@NathanHB NathanHB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR ! It feels much cleaner now

@NathanHB
Copy link
Member

NathanHB commented Jul 9, 2024

Do you plan on updating the doc in this PR ?

@clefourrier
Copy link
Member Author

I wanted to wait for #212, #213 and #214 to all be merged to come back to the README, wdyt?

@NathanHB
Copy link
Member

NathanHB commented Jul 9, 2024

Sounds good to me :)

@clefourrier clefourrier merged commit 3aaec22 into main Jul 9, 2024
hynky1999 pushed a commit that referenced this pull request May 22, 2025
* replaced json tasks by python tasks

---------

Co-authored-by: Nathan Habib <[email protected]>
NathanHB added a commit that referenced this pull request Sep 19, 2025
* replaced json tasks by python tasks

---------

Co-authored-by: Nathan Habib <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants