fix(dataset): use revision-safe Hub cache for downloaded datasets#3233
Merged
imstevenpmwork merged 6 commits intomainfrom Mar 27, 2026
Merged
fix(dataset): use revision-safe Hub cache for downloaded datasets#3233imstevenpmwork merged 6 commits intomainfrom
imstevenpmwork merged 6 commits intomainfrom
Conversation
…uce hub cache support - Updated DatasetConfig and LeRobotDatasetMetadata to clarify root directory behavior and introduce a dedicated hub cache for downloads. - Refactored LeRobotDataset and StreamingLeRobotDataset to utilize the new hub cache and improve directory management. - Added tests to ensure correct behavior when using the hub cache and handling different revisions without a specified root directory.
- Updated LeRobotDataset to store the requested root path separately from the actual root path. - Adjusted metadata loading to use the requested root, enhancing clarity and consistency in directory management.
github-actions
bot
added
dataset
imstevenpmwork
changed the title
Collaborator
Author
|
CI Failures related to: #3231 are omitted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes: #3229
Added:
has_legacy_hub_download_metadatato utils_requested_rootadded in the different creation methods for consistency (and use metadata filed as single source of truth)_rootfrom the reader public_downloadpath inLeRobotDatasetin addition to the test for the metadataCI Full run: https://github.com/huggingface/lerobot/actions/runs/23666039167