fix(deps): breaking change from transformers 5.4.0#3231
Merged
imstevenpmwork merged 5 commits intomainfrom Mar 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates XVLA (Florence2) and Wall-X (Qwen2.5-VL MoE) model implementations to adapt to a Transformers 5.4+ breaking change where is_flash_attn_greater_or_equal_2_10 was removed.
Changes:
- Replace
is_flash_attn_greater_or_equal_2_10imports withis_flash_attn_greater_or_equal. - Update FlashAttention version checks used to determine causal mask alignment behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/lerobot/policies/xvla/modeling_florence2.py | Switches FlashAttention version helper import/call used by Florence2 FlashAttention module. |
| src/lerobot/policies/wall_x/qwen_model/qwen2_5_vl_moe.py | Switches FlashAttention version helper import/call used by Qwen2.5-VL FlashAttention module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Maxime Ellerbach <maxime@ellerbach.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Maxime Ellerbach <maxime@ellerbach.net>
3 tasks
This was referenced Mar 27, 2026
Collaborator
|
Merging this one despite the CI red, so we can unblock other PRs. The failures related to transformers v5.4 & the logins test will be addressed shortly |
imstevenpmwork
added a commit
that referenced
this pull request
Mar 30, 2026
This reverts commit 0750286.
imstevenpmwork
added a commit
that referenced
this pull request
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing transformers breaking changes from transformers
5.4.0is_flash_attn_greater_or_equal_2_10tois_flash_attn_greater_or_equal("2.1.0"). Explained here@dataclassfrom class that inherit fromPretrainedConfig. Explained hereFinally, we bumped the minimum requirements of LeRobot to use
transformers>=5.4.0to avoid any compatibility issues with versions that match:transformers>=5.3.0,<5.4.0that would be caused by the deletion of@dataclass