Skip to content

Conversation

@AdilZouitine
Copy link
Collaborator

@AdilZouitine AdilZouitine commented Apr 24, 2025

Apply necessary changes to use latest versions of torch and torchcodec.

The torch 2.7.0 release notes confirm that the verbose argument in LRScheduler has been deprecated and removed. To maintain compatibility, we update our tests by dropping verbose from the assertions.

@imstevenpmwork imstevenpmwork changed the title [CI] Bump torch version feat(dependency): Bump torch versions beyond 2.6.0 & torchcodec beyond 0.2.1 Apr 24, 2025
@imstevenpmwork imstevenpmwork changed the title feat(dependency): Bump torch versions beyond 2.6.0 & torchcodec beyond 0.2.1 feat(dependency): Bump torch beyond 2.6.0 & torchcodec beyond 0.2.1 Apr 24, 2025
@imstevenpmwork imstevenpmwork marked this pull request as draft April 24, 2025 10:11
@imstevenpmwork imstevenpmwork added the dependencies Concerns about external packages, libraries, or versioning label Apr 24, 2025
@imstevenpmwork imstevenpmwork marked this pull request as ready for review April 24, 2025 15:19
@imstevenpmwork imstevenpmwork marked this pull request as draft April 24, 2025 17:44
"termcolor>=2.4.0",
"torch>=2.2.1,<2.7",
"torchcodec==0.2.1; sys_platform != 'win32' and (sys_platform != 'linux' or (platform_machine != 'aarch64' and platform_machine != 'arm64' and platform_machine != 'armv7l')) and (sys_platform != 'darwin' or platform_machine != 'x86_64')",
"torch>=2.2.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be torch>=2.7.0 if there are truly breaking changes

"torch>=2.2.1,<2.7",
"torchcodec==0.2.1; sys_platform != 'win32' and (sys_platform != 'linux' or (platform_machine != 'aarch64' and platform_machine != 'arm64' and platform_machine != 'armv7l')) and (sys_platform != 'darwin' or platform_machine != 'x86_64')",
"torch>=2.2.1",
"torchcodec>=0.2.1; sys_platform != 'win32' and (sys_platform != 'linux' or (platform_machine != 'aarch64' and platform_machine != 'arm64' and platform_machine != 'armv7l')) and (sys_platform != 'darwin' or platform_machine != 'x86_64')",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in here:
torchcodec>=0.3.0

@AdilZouitine
Copy link
Collaborator Author

Closed because this fix the issue: #1127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Concerns about external packages, libraries, or versioning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants