Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default cast for sliced list arrays if pyarrow >= 4 #2497

Merged
merged 3 commits into from
Jun 14, 2021

Conversation

albertvillanova
Copy link
Member

@albertvillanova albertvillanova commented Jun 14, 2021

From pyarrow version 4, it is supported to cast sliced lists.

This PR uses default pyarrow cast in Datasets to cast sliced list arrays if pyarrow version is >= 4.

In relation with PR #2461 and #2490.

cc: @lhoestq, @abhi1thakur, @SBrandeis

@SBrandeis
Copy link
Contributor

I believe we don't use PyArrow >= 4.0.0 because of some segfault issues:

"pyarrow>=1.0.0,!=4.0.0",

Can you confirm @lhoestq ?

@albertvillanova
Copy link
Member Author

albertvillanova commented Jun 14, 2021

@SBrandeis pyarrow version 4.0.1 has fixed that issue: #2489 😉

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks ! I didn't know it was supported now :)

@lhoestq lhoestq merged commit d6d0ede into huggingface:master Jun 14, 2021
@albertvillanova albertvillanova added this to the 1.9 milestone Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants