Support sliced list arrays in cast #2461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is this issue in pyarrow:
However in
Dataset.cast
we slice tables to cast their types (it's memory intensive), so we have the same issue.Because of this it is currently not possible to cast a Dataset with a Sequence feature type (unless the table is small enough to not be sliced).
In this PR I fixed this by resetting the offset of
pyarrow.ListArray
arrays to zero in the table before casting.I used
pyarrow.compute.subtract
function to update the offsets of the ListArray.cc @abhi1thakur @SBrandeis