Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use pyarrow 4.0.0 since it segfaults when casting a sliced ListArray of integers #2268

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Apr 27, 2021

This test tests/test_table.py::test_concatenation_table_cast segfaults with the latest update of pyarrow 4.0.0.
Setting pyarrow<4.0.0 for now. I'll open an issue on JIRA once I know more about the origin of the issue

@albertvillanova
Copy link
Member

@lhoestq note that the segfault also occurs on Linux.

@lhoestq lhoestq changed the title Don't use pyarrow 4.0.0 since it segfaults on windows Don't use pyarrow 4.0.0 since it segfaults when casting a sliced ListArray of integers Apr 27, 2021
@lhoestq
Copy link
Member Author

lhoestq commented Apr 27, 2021

Created the ticket at
https://issues.apache.org/jira/browse/ARROW-12568

@lhoestq lhoestq merged commit ab209bc into master Apr 27, 2021
@lhoestq lhoestq deleted the dont-use-pyarrow-4.0.0 branch April 27, 2021 13:43
@symeneses
Copy link

@lhoestq the ticket you mentioned is now in state resolved. Pyarrow supports AArch64 after version 4.0.0. Because of this restriction datasets is not installing in AArch64 systems.

Narsil added a commit to huggingface/tokenizers that referenced this pull request Dec 15, 2021
Narsil added a commit to huggingface/tokenizers that referenced this pull request Dec 15, 2021
* Clippy fixes.

* Drop support for Python 3.6

* Remove other 3.6

* Re-enabling caches for build (5h + seems too long and issue seems
solved)

actions/runner-images#572

* `npm audit fix`.

* Fix yaml ?

* Pyarrow issue fixed: huggingface/datasets#2268

* Installing dev libraries.

* Install python dev elsewhere ?

* Typo.

* No sudo.

* ...

* Testing the GH again.

* Maybe v2 will fix ?

* Fixing tests on MacOS Python 3.8+
McPatate pushed a commit to huggingface/tokenizers that referenced this pull request Dec 15, 2021
* Clippy fixes.

* Drop support for Python 3.6

* Remove other 3.6

* Re-enabling caches for build (5h + seems too long and issue seems
solved)

actions/runner-images#572

* `npm audit fix`.

* Fix yaml ?

* Pyarrow issue fixed: huggingface/datasets#2268

* Installing dev libraries.

* Install python dev elsewhere ?

* Typo.

* No sudo.

* ...

* Testing the GH again.

* Maybe v2 will fix ?

* Fixing tests on MacOS Python 3.8+
McPatate pushed a commit to huggingface/tokenizers that referenced this pull request Dec 22, 2021
* Clippy fixes.

* Drop support for Python 3.6

* Remove other 3.6

* Re-enabling caches for build (5h + seems too long and issue seems
solved)

actions/runner-images#572

* `npm audit fix`.

* Fix yaml ?

* Pyarrow issue fixed: huggingface/datasets#2268

* Installing dev libraries.

* Install python dev elsewhere ?

* Typo.

* No sudo.

* ...

* Testing the GH again.

* Maybe v2 will fix ?

* Fixing tests on MacOS Python 3.8+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants