Skip to content

Commit

Permalink
Don't use pyarrow 4.0.0 since it segfaults when casting a sliced List…
Browse files Browse the repository at this point in the history
…Array of integers (#2268)

* don't use pyarrow 4.0.0 since it segfaults on windows

* pin to 3.0.0 in CI tests
  • Loading branch information
lhoestq authored Apr 27, 2021
1 parent 8e903b5 commit ab209bc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- run: source venv/bin/activate
- run: pip install .[tests]
- run: pip install -r additional-tests-requirements.txt --no-deps
- run: pip install pyarrow --upgrade
- run: pip install pyarrow==3.0.0
- run: HF_SCRIPTS_VERSION=master python -m pytest -sv ./tests/

run_dataset_script_tests_pyarrow_1:
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
- run: "& venv/Scripts/activate.ps1"
- run: pip install .[tests]
- run: pip install -r additional-tests-requirements.txt --no-deps
- run: pip install pyarrow --upgrade
- run: pip install pyarrow==3.0.0
- run: $env:HF_SCRIPTS_VERSION="master"
- run: python -m pytest -sv ./tests/

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"numpy>=1.17",
# Backend and serialization.
# Minimum 1.0.0 to avoid permission errors on windows when using the compute layer on memory mapped data
"pyarrow>=1.0.0",
"pyarrow>=1.0.0<4.0.0",
# For smart caching dataset processing
"dill",
# For performance gains with apache arrow
Expand Down

0 comments on commit ab209bc

Please sign in to comment.