Robot loadFile and parseHelp tests and method improvements #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 29, 2017 15:46
replace mock test script function with a real script file and pass it through `loadFile` without mocking `parseHelp` to show script loading fails on comment parsing - re issue hubotio#1375
trying to parseHelp for a coffeescript file causes unexpexted syntax errors becuase coffe-script is not registered - causes hubotio#1376
fixes hubotio#1376 - also passing new tests for coffescript documentation with parseHelp
fixes hubotio#1375 - also tweaked the existing support to accept indented comments
Unsupported extensions were silently omitted from loadFile, this made it hard to debug. The accepted extensions were also incorrect due to use of require.extensions which is depreciated and contained types that are incompatible with hubot to load as scripts - fixes hubotio#1377 related hubotio#1355
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will address several issues in hubot v3 script loading.
Currently just adds failing tests for #1375