Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

robot.loadFile can't require coffeescript #1376

Closed
timkinnane opened this issue Jul 29, 2017 · 1 comment
Closed

robot.loadFile can't require coffeescript #1376

timkinnane opened this issue Jul 29, 2017 · 1 comment
Labels
stale

Comments

@timkinnane
Copy link

In hubot v3, I'm assuming its still intended to be compatible with loading legacy coffeescript files? There's still all the code parsing coffescript comments for documentation, but if robot.loadFile actually tries to require a .coffee file it throws unexpected token errors, because coffeescript is not registered.
@timkinnane timkinnane mentioned this issue Jul 29, 2017
Closed
timkinnane pushed a commit to timkinnane/hubot-async that referenced this issue Jul 29, 2017
test(robot): test robot.loadFile with coffee script file
b8b2895 
trying to parseHelp for a coffeescript file causes unexpexted syntax errors becuase coffe-script is not registered - causes hubotio#1376
timkinnane pushed a commit to timkinnane/hubot-async that referenced this issue Jul 29, 2017
fix(robot): register extension for legacy script loading
75885c8 
fixes hubotio#1376 - also passing new tests for coffescript documentation with parseHelp
@stale
Copy link

stale bot commented Oct 27, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 27, 2017
@stale stale bot closed this as completed Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkinnane