Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add id based entry tactic. #1940

Merged
merged 11 commits into from
Apr 6, 2023
Merged

Add id based entry tactic. #1940

merged 11 commits into from
Apr 6, 2023

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Apr 5, 2023

This should allow the following:

Mission(
    # Specifically take over actor "traffic-replay-12"
    entry_tactic=sstudio.types.IdEntryTactic("traffic-replay-12"),
)

@qianyi-sun Please advise me if we should also add a destination-only Route.

See CHANGELOG.md

saulfield and others added 4 commits April 5, 2023 10:16
* Dummy commit

* Remove process call in sumo map class

* Try adding timeout

* Update changelog
@Gamenot
Copy link
Collaborator Author

Gamenot commented Apr 5, 2023

Looking at this after I implemented it, I suspect that a better implementation would require the ActorCaptureManager types to register entry tactic types that they handle so that conflicts in managed EntryTactic types can be detected between the managers and SMARTS could handle delegation of agents to these managers rather than unrestricted by the managers to all agents being the default.

@Gamenot Gamenot linked an issue Apr 6, 2023 that may be closed by this pull request
CHANGELOG.md Outdated Show resolved Hide resolved
smarts/core/actor_capture_manager.py Outdated Show resolved Hide resolved
smarts/core/id_actor_capture_manager.py Show resolved Hide resolved
@Gamenot Gamenot merged commit db7706b into master Apr 6, 2023
@Gamenot Gamenot deleted the tucker/add-id-entry-tactic branch April 6, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add EntryTactic to directly take over vehicles
3 participants