Fix sumo scenario build hanging #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gamenot
approved these changes
Apr 5, 2023
| @@ -168,7 +168,7 @@ def from_spec(cls, map_spec: MapSpec): | |||
| # coordinates are relative to the origin). | |||
| G._shifted_by_smarts = True | |||
|
|
|||
| junction_check_proc.join() | |||
| junction_check_proc.join(5) | |||
There was a problem hiding this comment.
Very interesting. I assume somehow File, Process, or mmap is hanging.
Adaickalavan
approved these changes
Apr 5, 2023
Gamenot
added a commit
that referenced
this pull request
Apr 6, 2023
* Fix sumo scenario build hanging (#1941) * Dummy commit * Remove process call in sumo map class * Try adding timeout * Update changelog * Add id based entry tactic. * Fix Mission is None in id capture manager. * Fix typing. * Add time range. * Ensure that IdEntryTactic is tested. * Fix naming. * Mangle method that should not be called. * Fix typing test. * Apply suggestions from code review Co-authored-by: Saul Field <[email protected]> Co-authored-by: adai <[email protected]> * Clarify order of operations. --------- Co-authored-by: Saul Field <[email protected]> Co-authored-by: adai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #1816.
It seems that
junction_check_proccan sometimes not return. Since there was no timeout argument given tojoin, this could block infinitely.