Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix local traffic #1628

Merged
merged 9 commits into from
Sep 14, 2022
Merged

Fix local traffic #1628

merged 9 commits into from
Sep 14, 2022

Conversation

Gamenot
Copy link
Collaborator

@Gamenot Gamenot commented Sep 13, 2022 •
edited
Loading

  • This fixes two issues with the local_traffic_provider
    • Issue 1: Vehicles were stopping randomly. This was due to an optimization that was storing old caches individually in the internal traffic actors.
    • Issue 2: Newest actor was removed when an actor left the traffic provider. Similar to previous issue this had to do with using a local reference from a loop rather than recovering the agent from the id(which did no cause an error from a quirk of python scope rules.)
    • Minor issue: Vehicles that recently enter now hold lane for a short amount of time.

This should be merged into both develop and comp-1 asap.

@Gamenot Gamenot added the Urgent urgent issue needs to be fixed asap label Sep 13, 2022
Adaickalavan
Adaickalavan approved these changes Sep 14, 2022
View reviewed changes
Copy link
Member

@Adaickalavan Adaickalavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the pytype errors before merging.

@Gamenot Gamenot linked an issue Sep 14, 2022 that may be closed by this pull request
Vehicles collide and pile up in 3lane_cut_in scenario #1629
Closed
@qianyi-sun qianyi-sun mentioned this pull request Sep 14, 2022
Closed
qianyi-sun
qianyi-sun approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@qianyi-sun qianyi-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine, thanks Tucker!

@qianyi-sun
Copy link
Contributor

Need to fix the pytype errors before merging.

@Adaickalavan After this gets merged into develop, please update comp-1 accordingly, thanks!

@Gamenot Gamenot merged commit 83a8b7f into develop Sep 14, 2022
Gamenot added a commit that referenced this pull request Sep 14, 2022
@Gamenot @qianyi-sun @Adaickalavan
Fix local traffic (#1628)
c677953 
* Fix local traffic

* Fix bad attribute call

* Remove set logger levels.

* Local traffic actors avoid dangerous lane change.

* tune scenario.py

* another improvement

* Update smarts/scenarios/straight/3lane_cut_in/scenario.py

Co-authored-by: adai <[email protected]>

* format

* Fix typing

Co-authored-by: qianyi-sun <[email protected]>
Co-authored-by: Qianyi Sun <[email protected]>
Co-authored-by: adai <[email protected]>
@Gamenot Gamenot deleted the fix_traffic branch September 14, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulfield saulfield saulfield approved these changes

@Adaickalavan Adaickalavan Adaickalavan approved these changes

@qianyi-sun qianyi-sun qianyi-sun approved these changes

Assignees
No one assigned
Labels
Urgent urgent issue needs to be fixed asap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vehicles collide and pile up in 3lane_cut_in scenario
4 participants
@Gamenot @qianyi-sun @saulfield @Adaickalavan