Skip to content

Commit

Permalink
Fixed an error on closing envision when envision is connected. (#1843)
Browse files Browse the repository at this point in the history
* Fixed an error on closing envision when envision is connected.

* Update changelog.
  • Loading branch information
Gamenot authored Feb 8, 2023
1 parent 8b3e66f commit d95f079
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Copy and pasting the git commit messages is __NOT__ enough.
### Changed
### Deprecated
### Fixed
- Fixed an exit error that occurs when envision attempts to close down.
- Clarified the actions for `ActionSpaceType.Continuous` and `ActionSpaceType.ActuatorDynamic` in their respective docstrings.
- Excluded from wheel any scenario build files in pattern `smarts/**/build/**/*.xml`.
### Removed
Expand Down
4 changes: 2 additions & 2 deletions envision/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ def _write_log_state(
with path.open("w", encoding="utf-8") as f:
while True:
state = queue.get()
if type(state) is Client.QueueDone:
if isinstance(state, Client.QueueDone) or state is None:
break

if not isinstance(state, str):
Expand Down Expand Up @@ -260,7 +260,7 @@ def on_open(ws):

while True:
state = state_queue.get()
if isinstance(type(state), Client.QueueDone):
if isinstance(state, Client.QueueDone) or state is None:
break

optionally_serialize_and_write(state, ws)
Expand Down

0 comments on commit d95f079

Please sign in to comment.