Use the Tokimeki / old Juiced 2 method for Breath of Fire III #18653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrydgard
added
the
Code Cleanup
|
@unknownbrackets summoning for opinion since I'm deleting your old workaround here :) It's always a bit iffy to go from general hack to compat.ini option, but I still would argue that in this case it's cleaner this way. |
Allows us to delete a bunch of complex code.
hrydgard
force-pushed
the
simplify-bof-rendering
branch
from
fc6b9cd
to
0b6ea4b
Compare
|
I'm going to get this in, it'll make some things I want to do like #18646 easier. Hopefully we can make the framebuffer-merge heuristic safe enough in the future to enable without a flag - the only known breakage when doing so is that it slows down Juiced 2 drastically since it does self-texturing within the merged range, which isn't an issue in BOF. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18650 / #6379
Merges the two framebuffers into one, instead of complex logic to pick the right texture from the coordinates.
Allows us to delete a piece of complex code from the renderers, but for now at least, requires us to enable the compat flag.
I don't think there are any other known games that rely on this?