-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Through-mode smart texture filtering #18646
Conversation
Breaks BoF III due to DetectOffsetTexture not working correctly with unscaled coordinates. |
Due to "dubious results" and the fact it's never soo black and white with people's preferences, it probably shouldn't replace any of the existing filtering types, but it would be fine either as an option or as a new type of filtering combined with auto max. Naming might be hard, but it could use tooltip for explanation or just use "smart" as you proposed, and be explained somewhere in the docs. |
Yeah, probably the best. Just undecided if it should be separate, since it makes sense to combine it both with the old Auto and the newer Auto Max Quality.. |
We can add a single tick box ☑️. |
Also if this proves to be useful for some 3D games, then auto max quality will benefit from both mipmap generation and smart filtering. |
ee6ada2
to
09d8bc5
Compare
This no longer breaks BOFIII (after #18653 ). Went ahead and added a new setting to play with. It's quite nice now in Ridge Racer menus, and many other games too, if you prefer a sharper pixel-perfect look over sometimes-ugly bilinear. We are not yet able to detect this in situations where games don't use through-mode for their UI, unfortunately. |
f00c114
to
4d987fd
Compare
4d987fd
to
52d05aa
Compare
I feel this is useful enough already that we can include it in 1.17, though plan to improve it further in 1.18. |
Adds a new option, "Smart 2D texture filtering" to switch to nearest (pixel) filtering mode if we detect "pixel-mapped" graphics in RECT draws.
Helps #18460 (the issue with the idea), though we might want a compat flag to argue that it fixes it.
Things that get fixed when enabled:
Things I hoped would be fixed but are NOT:
Dubious results:
Untested:
Draft because there are some open questions:Should this be a setting, or another texture filtering mode along with Auto etc? "Smart?". Combine with Auto max quality?A new settingTo fix dialog frames in FFI, which are mistakenly filtered causing color fringes, we need to accept 1-dimensional stretching, which isn't true pixel mapping but due to the nature of the situation, it acts like it in this case.(this seems ok, let's keep it)Additional fixes since original PR:
Possible future expansion: