Vulkan: Use depth clamping, where available #10454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was slightly off in the accurate depth path.
Just in case some game stores it somewhere, but also makes it simpler to write tests against hardware.
This fixes, for example, Shadow of Destiny, even without the hack.
hrydgard
reviewed
Dec 27, 2017
| @@ -37,6 +37,9 @@ alignas(16) GPUgstate gstate; | |||
| // Let's align this one too for good measure. | |||
| alignas(16) GPUStateCache gstate_c; | |||
|
|
|||
| // For save state compatibility. | |||
| static int savedContextVersion = 1; | |||
There was a problem hiding this comment.
This should be set to 1 somewhere when a game is started, right? Otherwise it could leak over to the second game you run in a session..
Should really rearchitect the whole emu to avoid all these globals... oh well.
There was a problem hiding this comment.
Oops, yes, thanks.
Once you have one global, it's kinda hard to avoid more.
-[Unknown]
|
Seems Adreno is stepping up and implementing a lot of optional features and extensions in later drivers. Mali lagging behind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows depth clamping to work correctly, and uses the full 24 bits of depth when it's available.
According to vulkan.gpuinfo.org, some mobile chips support this, although it's mostly just desktop.
-[Unknown]