Support multiple languages #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hql287 hit me up when the translation system is up to date, I'd like to add the italian language. |
|
Will do! The lovely folks at Crowin just decided to give Manta a free plan as being an open-source project and I’m setting it up at the moment. Will let you know when everything is ready! |
Closed
|
Hey @hql287 I don't see the update, but it's easy to find the project on Crowdin and work there so I already did it (part of it, will finish tomorrow). |
- Added tranlsation for Settings page - Refactored Form translation - Move common translation to a separate file
Also updated Form container
|
Reviewed the whole PR everything looks nice to me, LGTM ! 😃 |
|
Thanks, @SkyzohKey. Still have some components left to be refactored though. Will try to get this done asap so people can work on the translation. |
This was referenced Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a working demo (Form tab only) which includes translation for English, French and Vietnamese. User can set the default language in settings, hit save and the app's language would be updated immediately.
Please have a look at a translation file format and let me know what you think.
@SkyzohKey Can you review this? Thanks!
Todos:
previewWindowtourWindowFix #9