Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Warning Message (Better UX) #12

Closed
hql287 opened this issue Nov 15, 2017 · 6 comments
Closed

Update Warning Message (Better UX) #12

hql287 opened this issue Nov 15, 2017 · 6 comments

Comments

@hql287
Copy link
Owner

hql287 commented Nov 15, 2017

No description provided.

@hql287 hql287 added this to the Production milestone Nov 15, 2017
@hql287 hql287 self-assigned this Nov 15, 2017
@QuadDepo
Copy link

QuadDepo commented Dec 8, 2017

More information / screenshot on this?

@hql287
Copy link
Owner Author

hql287 commented Dec 8, 2017

Hi Ryan

Right now when you try to delete an invoice/contact, this warning message will show up.

screen shot 2017-12-08 at 15 54 08

"Are You Sure" is bad. I would like to improve it a little bit. Something that's more meaningful but concise. This article is pretty good, in my opinion.

@hql287
Copy link
Owner Author

hql287 commented Dec 8, 2017

@QuadDepo Are you interested working on a PR for this?

@hql287 hql287 removed their assignment Dec 8, 2017
@QuadDepo
Copy link

QuadDepo commented Dec 9, 2017

Yea sure i can give it a try :)

@hql287
Copy link
Owner Author

hql287 commented Dec 9, 2017

Great!

@hql287 hql287 removed this from the V1.1.0 milestone Jan 5, 2018
@hql287
Copy link
Owner Author

hql287 commented Jan 31, 2018

This should be fixed with #187

@hql287 hql287 closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants