Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove discount when editing #227

Closed
3 tasks
alexanderbluhm opened this issue Feb 21, 2018 · 2 comments
Closed
3 tasks

Can't remove discount when editing #227

alexanderbluhm opened this issue Feb 21, 2018 · 2 comments
Assignees
Labels

Comments

@alexanderbluhm
Copy link

alexanderbluhm commented Feb 21, 2018

Is it a bug or a feature request?

  • [x ] It's a bug.
  • I'm requesting a new feature.

Which version are you using?

  • [x ] macOS
  • Windows
  • Linux

Which is the version/distribution of the OS?

I'm using macOS High Sierra

Describe your issue

I can't remove the discount field after creating an invoice with discount.

Steps to replicate

  1. Create a new invoice with discount. (I choose 10%)
  2. Edit the invoice and disable the discount field.
  3. Klick "update"
  4. View the invoice, but the discount is still there.
@hql287 hql287 self-assigned this Feb 22, 2018
@hql287 hql287 added the bug label Feb 22, 2018
@hql287
Copy link
Owner

hql287 commented Feb 22, 2018

@IL4Miy : Thanks for reporting the issue. Looks like the calculation is still correct but it still displays the discount information on the template. Investigating it right now!

@hql287
Copy link
Owner

hql287 commented Mar 1, 2018

Ok, found the culprit. The current implementation of updating a doc will merge the current doc with the new data so all existing key will remain in the doc. It's an easy fix and will be included in the release tomorrow.

hql287 added a commit that referenced this issue Mar 2, 2018
Reimplemented invoice update action. Fix #227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants