Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplemented invoice update action #237

Merged
merged 5 commits into from
Mar 2, 2018
Merged

Conversation

hql287
Copy link
Owner

@hql287 hql287 commented Mar 2, 2018

Fix #227

hql287 added 5 commits March 2, 2018 16:05
updateDoc now take only 2 argument, the databse and the doc to be updated. This means the doc argument need to have both _id and _rev data
+ Removed (unnecessary) comments
+ Refactored updateInvoice action, now take only one argument – the updatedInvoice (which should contains both _id and _rev data)
+ Updated corresponding tests
+ Make sure to retrieve the _rev data when updating the doc
+ Updated corresponding test
+ Make sure actions work with the new updateDoc in pouchDB helper
+ Added news tests and updated old ones
+ Added mock function for getSingleDoc
Make sure updateInvoice now take only one argument
@hql287 hql287 added the bug label Mar 2, 2018
@hql287 hql287 self-assigned this Mar 2, 2018
@hql287 hql287 merged commit 355341e into dev Mar 2, 2018
@hql287 hql287 deleted the reimplement-invoice-update branch March 2, 2018 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant