Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Remove algernon instances after tests are finished. #253

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Fix: Remove algernon instances after tests are finished. #253

merged 2 commits into from
Jun 8, 2022

Conversation

gwauge
Copy link
Contributor

@gwauge gwauge commented May 30, 2022

@gwauge gwauge requested a review from yannik-dittmar May 30, 2022 16:37
yannik-dittmar
yannik-dittmar approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@yannik-dittmar yannik-dittmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks hacky to me... But if it works it should be good enough for the test

@gwauge gwauge requested a review from yannik-dittmar June 3, 2022 11:15
yannik-dittmar
yannik-dittmar approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@yannik-dittmar yannik-dittmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this is intentional, but every time you run a test, Algernon is enabled, even if you had disabled it before starting the test. However, since I can't think of any situation where something like this would cause problems, I approve this PR.

@gwauge gwauge merged commit e87e90a into development Jun 8, 2022
@gwauge gwauge deleted the instance-disposal branch June 8, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannik-dittmar yannik-dittmar yannik-dittmar approved these changes

Assignees

@gwauge gwauge

@FSadrieh FSadrieh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Algernon instances used in tests aren't properly disposed
3 participants
@gwauge @yannik-dittmar @FSadrieh